linux-kernel - Re: [PATCH] module: Remove the unused function within

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+0VAr21hlIdrxyp@chrisdown.name>
Date:   Wed, 15 Feb 2023 17:23:14 +0000
From:   Chris Down <chris@...isdown.name>
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, mcgrof@...nel.org,
        ndesaulniers@...gle.com, trix@...hat.com,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org, llvm@...ts.linux.dev,
        Abaci Robot <abaci@...ux.alibaba.com>,
        Song Liu <song@...nel.org>
Subject: Re: [PATCH] module: Remove the unused function within

+Cc: Song

Nathan Chancellor writes:
>On Wed, Feb 15, 2023 at 04:47:44PM +0000, Chris Down wrote:
>> Jiapeng Chong writes:
>> > The function within is defined in the main.c file, but not called
>> > elsewhere, so remove this unused function.
>>
>> Huh? It's used by __module_text_address(), no?
>
>Not after commit 2ece476a2346 ("module: replace module_layout with
>module_memory") in -next. This patch should have a fixes tag, even if
>the warning is currently hidden behind W=1.

Huh, I thought I had checked out latest -next, but must have not done so 
somehow :-) Mea culpa.

If it's only in -next then no Fixes needed, since there's no stable rev yet.

Jiapeng, in future, please make sure to cc the author of related commits when 
reporting stuff like this :-) It helps people to update their patches.

Song, you probably want to update your patch.