| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Feb 2023 05:12:20 +0800
From: kernel test robot <lkp@...el.com>
To: Angelo Compagnucci <angelo.compagnucci@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev,
Angelo Compagnucci <angelo@...rulasolutions.com>,
Derek Kiernan <derek.kiernan@...inx.com>,
Dragan Cvetic <dragan.cvetic@...inx.com>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Thierry Reding <thierry.reding@...il.com>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
linux-pwm@...r.kernel.org
Subject: Re: [PATCH v3 1/3] misc: servo-pwm: driver for controlling servo
motors via PWM
Hi Angelo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-linus]
[also build test WARNING on linus/master v6.2-rc8]
[cannot apply to char-misc/char-misc-testing char-misc/char-misc-next next-20230217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Angelo-Compagnucci/misc-servo-pwm-Add-sysfs-entries-to-control-motor-angle/20230218-001254
patch link: https://lore.kernel.org/r/20230217161038.3130053-1-angelo%40amarulasolutions.com
patch subject: [PATCH v3 1/3] misc: servo-pwm: driver for controlling servo motors via PWM
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230218/202302180429.NvI1mwuf-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0ae16e16da0aa94de0d3ae63166f50a4a6fdef8a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Angelo-Compagnucci/misc-servo-pwm-Add-sysfs-entries-to-control-motor-angle/20230218-001254
git checkout 0ae16e16da0aa94de0d3ae63166f50a4a6fdef8a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/misc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302180429.NvI1mwuf-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/mm_types_task.h:16,
from include/linux/mm_types.h:5,
from include/linux/buildid.h:5,
from include/linux/module.h:14,
from drivers/misc/servo-pwm.c:7:
drivers/misc/servo-pwm.c: In function 'angle_show':
>> arch/loongarch/include/asm/page.h:23:25: warning: passing argument 2 of 'sysfs_emit' makes pointer from integer without a cast [-Wint-conversion]
23 | #define PAGE_SIZE (_AC(1, UL) << PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| long unsigned int
drivers/misc/servo-pwm.c:54:32: note: in expansion of macro 'PAGE_SIZE'
54 | return sysfs_emit(buf, PAGE_SIZE, "%u\n", data->angle);
| ^~~~~~~~~
In file included from include/linux/kobject.h:20,
from include/linux/module.h:21:
include/linux/sysfs.h:357:39: note: expected 'const char *' but argument is of type 'long unsigned int'
357 | int sysfs_emit(char *buf, const char *fmt, ...);
| ~~~~~~~~~~~~^~~
drivers/misc/servo-pwm.c: In function 'degrees_show':
>> arch/loongarch/include/asm/page.h:23:25: warning: passing argument 2 of 'sysfs_emit' makes pointer from integer without a cast [-Wint-conversion]
23 | #define PAGE_SIZE (_AC(1, UL) << PAGE_SHIFT)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| long unsigned int
drivers/misc/servo-pwm.c:84:32: note: in expansion of macro 'PAGE_SIZE'
84 | return sysfs_emit(buf, PAGE_SIZE, "%u\n", data->degrees);
| ^~~~~~~~~
include/linux/sysfs.h:357:39: note: expected 'const char *' but argument is of type 'long unsigned int'
357 | int sysfs_emit(char *buf, const char *fmt, ...);
| ~~~~~~~~~~~~^~~
vim +/sysfs_emit +23 arch/loongarch/include/asm/page.h
09cfefb7fa70c3 Huacai Chen 2022-05-31 10
09cfefb7fa70c3 Huacai Chen 2022-05-31 11 /*
09cfefb7fa70c3 Huacai Chen 2022-05-31 12 * PAGE_SHIFT determines the page size
09cfefb7fa70c3 Huacai Chen 2022-05-31 13 */
09cfefb7fa70c3 Huacai Chen 2022-05-31 14 #ifdef CONFIG_PAGE_SIZE_4KB
09cfefb7fa70c3 Huacai Chen 2022-05-31 15 #define PAGE_SHIFT 12
09cfefb7fa70c3 Huacai Chen 2022-05-31 16 #endif
09cfefb7fa70c3 Huacai Chen 2022-05-31 17 #ifdef CONFIG_PAGE_SIZE_16KB
09cfefb7fa70c3 Huacai Chen 2022-05-31 18 #define PAGE_SHIFT 14
09cfefb7fa70c3 Huacai Chen 2022-05-31 19 #endif
09cfefb7fa70c3 Huacai Chen 2022-05-31 20 #ifdef CONFIG_PAGE_SIZE_64KB
09cfefb7fa70c3 Huacai Chen 2022-05-31 21 #define PAGE_SHIFT 16
09cfefb7fa70c3 Huacai Chen 2022-05-31 22 #endif
09cfefb7fa70c3 Huacai Chen 2022-05-31 @23 #define PAGE_SIZE (_AC(1, UL) << PAGE_SHIFT)
09cfefb7fa70c3 Huacai Chen 2022-05-31 24 #define PAGE_MASK (~(PAGE_SIZE - 1))
09cfefb7fa70c3 Huacai Chen 2022-05-31 25
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Powered by blists - more mailing lists