linux-kernel - Re: [PATCH v3 1/3] misc: servo-pwm: driver for controlling servo motors via PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202302180513.AlOeQWNt-lkp@intel.com>
Date:   Sat, 18 Feb 2023 05:22:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Angelo Compagnucci <angelo.compagnucci@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Angelo Compagnucci <angelo@...rulasolutions.com>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
        linux-pwm@...r.kernel.org
Subject: Re: [PATCH v3 1/3] misc: servo-pwm: driver for controlling servo
 motors via PWM

Hi Angelo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-linus]
[also build test WARNING on linus/master v6.2-rc8]
[cannot apply to char-misc/char-misc-testing char-misc/char-misc-next next-20230217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Angelo-Compagnucci/misc-servo-pwm-Add-sysfs-entries-to-control-motor-angle/20230218-001254
patch link:    https://lore.kernel.org/r/20230217161038.3130053-1-angelo%40amarulasolutions.com
patch subject: [PATCH v3 1/3] misc: servo-pwm: driver for controlling servo motors via PWM
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230218/202302180513.AlOeQWNt-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0ae16e16da0aa94de0d3ae63166f50a4a6fdef8a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Angelo-Compagnucci/misc-servo-pwm-Add-sysfs-entries-to-control-motor-angle/20230218-001254
        git checkout 0ae16e16da0aa94de0d3ae63166f50a4a6fdef8a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/misc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302180513.AlOeQWNt-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from arch/sparc/include/asm/page.h:8,
                    from arch/sparc/include/asm/sparsemem.h:7,
                    from include/linux/numa.h:25,
                    from include/linux/cpumask.h:16,
                    from include/linux/mm_types_task.h:14,
                    from include/linux/mm_types.h:5,
                    from include/linux/buildid.h:5,
                    from include/linux/module.h:14,
                    from drivers/misc/servo-pwm.c:7:
   drivers/misc/servo-pwm.c: In function 'angle_show':
>> arch/sparc/include/asm/page_64.h:9:22: warning: passing argument 2 of 'sysfs_emit' makes pointer from integer without a cast [-Wint-conversion]
       9 | #define PAGE_SIZE    (_AC(1,UL) << PAGE_SHIFT)
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                      |
         |                      long unsigned int
   drivers/misc/servo-pwm.c:54:32: note: in expansion of macro 'PAGE_SIZE'
      54 |         return sysfs_emit(buf, PAGE_SIZE, "%u\n", data->angle);
         |                                ^~~~~~~~~
   In file included from include/linux/kobject.h:20,
                    from include/linux/module.h:21:
   include/linux/sysfs.h:357:39: note: expected 'const char *' but argument is of type 'long unsigned int'
     357 | int sysfs_emit(char *buf, const char *fmt, ...);
         |                           ~~~~~~~~~~~~^~~
   drivers/misc/servo-pwm.c: In function 'degrees_show':
>> arch/sparc/include/asm/page_64.h:9:22: warning: passing argument 2 of 'sysfs_emit' makes pointer from integer without a cast [-Wint-conversion]
       9 | #define PAGE_SIZE    (_AC(1,UL) << PAGE_SHIFT)
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                      |
         |                      long unsigned int
   drivers/misc/servo-pwm.c:84:32: note: in expansion of macro 'PAGE_SIZE'
      84 |         return sysfs_emit(buf, PAGE_SIZE, "%u\n", data->degrees);
         |                                ^~~~~~~~~
   include/linux/sysfs.h:357:39: note: expected 'const char *' but argument is of type 'long unsigned int'
     357 | int sysfs_emit(char *buf, const char *fmt, ...);
         |                           ~~~~~~~~~~~~^~~


vim +/sysfs_emit +9 arch/sparc/include/asm/page_64.h

f5e706ad886b6a include/asm-sparc/page_64.h Sam Ravnborg 2008-07-17   8  
f5e706ad886b6a include/asm-sparc/page_64.h Sam Ravnborg 2008-07-17  @9  #define PAGE_SIZE    (_AC(1,UL) << PAGE_SHIFT)
f5e706ad886b6a include/asm-sparc/page_64.h Sam Ravnborg 2008-07-17  10  #define PAGE_MASK    (~(PAGE_SIZE-1))
f5e706ad886b6a include/asm-sparc/page_64.h Sam Ravnborg 2008-07-17  11  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests