linux-kernel - Re: [regression] Bug 217037 - cmb attributes missing from the nvme class under sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <151a00d9-0ea2-eadb-72b4-fa8a2dd41bfc@kernel.dk>
Date:   Fri, 17 Feb 2023 14:23:50 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Keith Busch <kbusch@...nel.org>
Cc:     Linux regressions mailing list <regressions@...ts.linux.dev>,
        Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>, michallinuxstuff@...il.com
Subject: Re: [regression] Bug 217037 - cmb attributes missing from the nvme
 class under sysfs

On Thu, Feb 16, 2023 at 8:19 AM Keith Busch <kbusch@...nel.org> wrote:
>
> On Thu, Feb 16, 2023 at 10:28:55AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> > Hi, this is your Linux kernel regression tracker.
> >
> > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > kernel developer don't keep an eye on it, I decided to forward it by
> > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217037 :
> >
> > >  michallinuxstuff@...il.com 2023-02-14 14:16:26 UTC
> > >
> > > For the CMB-capable nvme ctrls, kernel was exposing couple of related attributes under the sysfs. E.g.
> > >
> > >
> > > # grep . /sys/class/nvme/nvme0/cmb*
> > > /sys/class/nvme/nvme0/cmb:cmbloc : x00000062
> > > /sys/class/nvme/nvme0/cmb:cmbsz  : x0008021d
> > > /sys/class/nvme/nvme0/cmbloc:98
> > > /sys/class/nvme/nvme0/cmbsz:524829
>
> The breakage is that the attributes are decided before we've setup the cmb
> regions. I'll send a fix shortly.

Michael, have you tested this? It's queued up for inclusion, but I don't
see any evidence that this was tested.

-- 
Jens Axboe