[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <610e8b6a-8e1c-753e-d2c9-0056a7804f9b@linaro.org>
Date: Sat, 18 Feb 2023 11:16:24 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Angelo Compagnucci <angelo.compagnucci@...il.com>
Cc: Angelo Compagnucci <angelo@...rulasolutions.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
"open list:GENERIC PWM SERVO DRIVER" <linux-pwm@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/3] dt-bindings: misc: servo-pwm: Add new bindings for
servo-pwm
On 17/02/2023 17:10, Angelo Compagnucci wrote:
> This binding describes the binding for controlling servo motors through
> pwm.
>
> Signed-off-by: Angelo Compagnucci <angelo@...rulasolutions.com>
> ---
> v2:
> * Converted old txt to yaml
> v3:
> * Fixed errors rised by make dt_binding_check
Still fails the tests.
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> .../devicetree/bindings/misc/servo-pwm.yaml | 57 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/servo-pwm.yaml
>
> diff --git a/Documentation/devicetree/bindings/misc/servo-pwm.yaml b/Documentation/devicetree/bindings/misc/servo-pwm.yaml
> new file mode 100644
> index 000000000000..73e81b939daf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/servo-pwm.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/servo-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Servo motor connected to PWM
> +
> +maintainers:
> + - Angelo Compagnucci <angelo@...rulasolutions.com>
> +
> +description:
> + Each servo is represented as a servo-pwm device.
> + The 20ms period is the accepted standard and so most of the motors
> + support it, while the positioning min/max duty cycle or the motor
> + degrees aperture vary lot between manufacturers.
> + The most common type of servo (SG90) has 180 degrees of movement
> + and moves between 0.5ms and 2.5ms duty cycle.
> +
> +properties:
> + compatible:
> + const: servo-pwm
> +
> + pwms:
> + maxItems: 1
> +
> + pwm-names: true
You got later feedback from Rob for v2, so this needs changes.
> +
> + degrees:
> + description:
> + How many degrees the motor can move.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + duty-min:
> + description:
> + Duty cycle for position the motor at 0 degrees.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + duty-max:
> + description:
> + Duty cycle for positioning the motor at "degrees" angle.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
Drop blank line.
Krzysztof
Powered by blists - more mailing lists