linux-kernel - Re: [PATCH v5 4/5] LoongArch: Add support for kernel relocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ac82f53aeb6a040be90eac2be7c64055e62f0ef.camel@xry111.site>
Date:   Fri, 17 Feb 2023 16:02:25 +0800
From:   Xi Ruoyao <xry111@...111.site>
To:     Youling Tang <tangyouling@...ngson.cn>,
        Huacai Chen <chenhuacai@...nel.org>,
        Jinyang He <hejinyang@...ngson.cn>
Cc:     Xuerui Wang <kernel@...0n.name>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/5] LoongArch: Add support for kernel relocation

On Fri, 2023-02-17 at 15:26 +0800, Youling Tang wrote:

> This config allows to compile kernel as PIE and to relocate it at
> any virtual address at runtime: this paves the way to KASLR.
> Runtime relocation is possible since relocation metadata are embedded
> into the kernel.
> 
> Signed-off-by: Youling Tang <tangyouling@...ngson.cn>
> Signed-off-by: Xi Ruoyao <xry111@...111.site> # Use arch_initcall
> Signed-off-by: Jinyang He <hejinyang@...ngson.cn> # Provide la_abs idea

Use Suggested-by if only "idea" is provided.

> +struct rela_la_abs {
> +               long offset;
> +               long symvalue;
> +};

Use one tab instead of two for the indent.

Otherwise LGTM.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University