linux-kernel - Re: [PATCH v5 4/5] LoongArch: Add support for kernel relocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc5b0403-ed2f-2dcf-11b9-e3be4642ddda@loongson.cn>
Date:   Fri, 17 Feb 2023 16:13:42 +0800
From:   Youling Tang <tangyouling@...ngson.cn>
To:     Xi Ruoyao <xry111@...111.site>
Cc:     Huacai Chen <chenhuacai@...nel.org>,
        Jinyang He <hejinyang@...ngson.cn>,
        Xuerui Wang <kernel@...0n.name>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/5] LoongArch: Add support for kernel relocation



On 02/17/2023 04:02 PM, Xi Ruoyao wrote:
> On Fri, 2023-02-17 at 15:26 +0800, Youling Tang wrote:
>
>> This config allows to compile kernel as PIE and to relocate it at
>> any virtual address at runtime: this paves the way to KASLR.
>> Runtime relocation is possible since relocation metadata are embedded
>> into the kernel.
>>
>> Signed-off-by: Youling Tang <tangyouling@...ngson.cn>
>> Signed-off-by: Xi Ruoyao <xry111@...111.site> # Use arch_initcall
>> Signed-off-by: Jinyang He <hejinyang@...ngson.cn> # Provide la_abs idea
>
> Use Suggested-by if only "idea" is provided.
In addition to the idea, the first draft code of la_abs is also
provided.

Maybe change it to the following,
   Signed-off-by: Jinyang He <hejinyang@...ngson.cn> # Provide la_abs 
relocation draft code

>
>> +struct rela_la_abs {
>> +               long offset;
>> +               long symvalue;
>> +};
>
> Use one tab instead of two for the indent.
My mistake.

Also the missing do_kaslr declaration will be added.

Youling.
> Otherwise LGTM.
>