linux-kernel - Re: [PATCH RESEND 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230217110413.GA28242@pengutronix.de>
Date:   Fri, 17 Feb 2023 12:04:13 +0100
From:   Michael Tretter <m.tretter@...gutronix.de>
To:     Shengyu Qu <wiagn233@...look.com>
Cc:     devicetree@...r.kernel.org, ezequiel@...guardiasur.com.ar,
        frattaroli.nicolas@...il.com, heiko@...ech.de,
        jacob-chen@...wrt.com, krzysztof.kozlowski+dt@...aro.org,
        krzysztof.kozlowski@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        mchehab@...nel.org, robh+dt@...nel.org, kernel@...gutronix.de
Subject: Re: [PATCH RESEND 2/2] arm64: dts: rockchip: Add RGA2 support to
 rk356x

Hi,

On Sun, 22 Jan 2023 00:50:37 +0800, Shengyu Qu wrote:
> Since we have the over-4GB problem now, should we mark this problem as a
> TODO or something?

I am not really sure where to put such a TODO to make it visible for people
that are running into the issue and to make sure that it is removed once it is
fixed.

Maybe it would be better to add error handling to the rga_buf_map function to
fail if the address of the buffer that should be mapped has the upper 32 bit
set and print a warning. Furthermore, the driver would be able to skip the
buffer and prevent potential memory corruption caused by the erroneous
mapping.

Unfortunately, I don't have hardware that allows me to test this.

Michael