linux-kernel - Re: [PATCH v2 34/47] clk: mediatek: Switch to module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ed4ca9f-bb75-2698-6c8a-2008b1320570@collabora.com>
Date:   Fri, 17 Feb 2023 12:18:55 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Chen-Yu Tsai <wenst@...omium.org>
Cc:     mturquette@...libre.com, sboyd@...nel.org, matthias.bgg@...il.com,
        johnson.wang@...iatek.com, miles.chen@...iatek.com,
        chun-jie.chen@...iatek.com, daniel@...rotopia.org,
        fparent@...libre.com, msp@...libre.com, nfraprado@...labora.com,
        rex-bc.chen@...iatek.com, zhaojh329@...il.com,
        sam.shih@...iatek.com, edward-jw.yang@...iatek.com,
        yangyingliang@...wei.com, granquet@...libre.com,
        pablo.sun@...iatek.com, sean.wang@...iatek.com,
        chen.zhong@...iatek.com, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v2 34/47] clk: mediatek: Switch to
 module_platform_driver() where possible

Il 17/02/23 05:19, Chen-Yu Tsai ha scritto:
> On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com> wrote:
>>
>> Lots of clock drivers have got both .probe() and a .remove() callbacks:
>> switch from builtin_platform_driver() to module_platform_driver() so
>> that we actually register the .remove() callback.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>>   drivers/clk/mediatek/clk-mt2701-aud.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2701-bdp.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2701-eth.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2701-g3d.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2701-hif.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2701-img.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2701-mm.c           | 3 +--
>>   drivers/clk/mediatek/clk-mt2701-vdec.c         | 3 +--
>>   drivers/clk/mediatek/clk-mt2712-bdp.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2712-img.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2712-jpgdec.c       | 3 +--
>>   drivers/clk/mediatek/clk-mt2712-mfg.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt2712-mm.c           | 3 +--
>>   drivers/clk/mediatek/clk-mt2712-vdec.c         | 3 +--
>>   drivers/clk/mediatek/clk-mt2712-venc.c         | 3 +--
>>   drivers/clk/mediatek/clk-mt6765-audio.c        | 3 +--
>>   drivers/clk/mediatek/clk-mt6765-cam.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt6765-img.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt6765-mipi0a.c       | 3 +--
>>   drivers/clk/mediatek/clk-mt6765-mm.c           | 3 +--
>>   drivers/clk/mediatek/clk-mt6765-vcodec.c       | 3 +--
>>   drivers/clk/mediatek/clk-mt6797-img.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt6797-mm.c           | 3 +--
>>   drivers/clk/mediatek/clk-mt6797-vdec.c         | 3 +--
>>   drivers/clk/mediatek/clk-mt6797-venc.c         | 3 +--
>>   drivers/clk/mediatek/clk-mt7622-aud.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt7622-eth.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt7622-hif.c          | 3 +--
>>   drivers/clk/mediatek/clk-mt7629-eth.c          | 1 -
> 
> This one looks fishy. It wasn't converted to the simple probe library.
> 
> Otherwise,
> 
> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>


Oh wow. Thanks for making me notice. Yeah you're right, mt7629-eth was not
converted to simple probe.... and I need to split sgmiisys and sgmiisys1.
This means that I need to change bindings and devicetree to add a new
compatible "mediatek,mt7629-sgmiisys1".

I won't do that in this series as I don't want to spam this huge amount of
patches to the devicetree list... but I'll do that as a separated series
that depends on this one.

So, for this one, I will simply drop the mt7629-eth change (as it's useless).

Thanks again!
Angelo