linux-kernel - Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <107be2c9-021b-85f6-d32d-ddb9e75ce24f@csgroup.eu>
Date:   Fri, 17 Feb 2023 13:46:54 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Baoquan He <bhe@...hat.com>, Arnd Bergmann <arnd@...db.de>
CC:     Matthew Wilcox <willy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Hellwig <hch@...radead.org>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        David Laight <David.Laight@...lab.com>,
        Stafford Horne <shorne@...il.com>,
        "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>,
        "linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>
Subject: Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC_IOREMAP



Le 17/02/2023 à 14:31, Baoquan He a écrit :
> On 02/16/23 at 04:18pm, Arnd Bergmann wrote:
>> On Thu, Feb 16, 2023, at 16:02, Baoquan He wrote:
>>> On 02/16/23 at 01:50pm, Matthew Wilcox wrote:
>>> It's not if including asm-generic/iomap.h. The ARCH_HAS_IOREMAP_xx is to
>>> avoid redefinition there.
>>>
>>> include/asm-generic/iomap.h:
>>> ----
>>> #ifndef ARCH_HAS_IOREMAP_WC
>>> #define ioremap_wc ioremap
>>> #endif
>>
>> I'd change that to the usual '#ifndef ioremap_wc' in that case.
> 
> Not sure if I got you. Kill all ARCH_HAS_IOREMAP_xxx in kernel? If yes,
> sounds like a good idea.
> 

At least kill that one at the first place in your series, and then the 
other ones in a follow-up series maybe.