linux-kernel - Re: [PATCH] padata: Make kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230217161450.blix7iek7duexlic@parnassus.localdomain>
Date:   Fri, 17 Feb 2023 11:14:50 -0500
From:   Daniel Jordan <daniel.m.jordan@...cle.com>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Steffen Klassert <steffen.klassert@...unet.com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] padata: Make kobj_type structure constant

On Fri, Feb 17, 2023 at 03:17:49AM +0000, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
> 
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

I see the symbol in .rodata now.  Thanks.

Acked-by: Daniel Jordan <daniel.m.jordan@...cle.com>

> ---
>  kernel/padata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e007b8a4b738..106d08ee9ce2 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -967,7 +967,7 @@ static const struct sysfs_ops padata_sysfs_ops = {
>  	.store = padata_sysfs_store,
>  };
>  
> -static struct kobj_type padata_attr_type = {
> +static const struct kobj_type padata_attr_type = {
>  	.sysfs_ops = &padata_sysfs_ops,
>  	.default_groups = padata_default_groups,
>  	.release = padata_sysfs_release,
> 
> ---
> base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
> change-id: 20230217-kobj_type-padata-288edceca728
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@...ssschuh.net>
>