linux-kernel - Re: [PATCH v2 net-next 0/5] add ethtool categorized statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230217164850.3jps62p2sfomee4r@skbuf>
Date:   Fri, 17 Feb 2023 18:48:50 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Alexander Lobakin <aleksander.lobakin@...el.com>
Cc:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        andrew@...n.ch, f.fainelli@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH v2 net-next 0/5] add ethtool categorized statistics

On Fri, Feb 17, 2023 at 03:54:48PM +0100, Alexander Lobakin wrote:
> From: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@...rochip.com>
> Date: Fri, 17 Feb 2023 16:32:06 +0530
> 
> > [PATCH v2 net-next 0/5] add ethtool categorized statistics
> 
> I'd like to see the cover letter's subject prefixed as well, e.g.
> 
> [PATCH v2 net-next 0/5] net: dsa: microchip: add ethtool categorized
> statistics
> 
> ...or so, depending on the usual prefix for ksz.
> Otherwise, it looks like you're adding something generic and only
> realize it targets a particular driver only after opening the thread itself.

+1

some people just look at the KSZ DSA driver all day, and so in their mind, it
then becomes implicit in the subject. But the cover letter description gets
turned by the netdev maintainers into a branch name for a merge commit, see:

fa15072b650a Merge branch 'sfc-devlink-support-for-ef100'
e9ab2559e2c5 Merge branch 'net-sched-transition-actions-to-pcpu-stats-and-rcu'
10d13421a6ae Merge branch 'net-core-commmon-prints-for-promisc'
a1d83abc8f2f Merge branch 'net-sched-retire-some-tc-qdiscs-and-classifiers'

and so, the naming of the cover letter has non-zero importance.

I agree that the contents of this patch set is absolutely disappointing
for someone reading the title and expecting some new ethtool counters.