linux-kernel - Re: [PATCH] staging: rtl8712: Fix multiple line dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d045c1a-5947-1ce4-b5cd-a1684761a812@gmail.com>
Date:   Mon, 20 Feb 2023 20:13:23 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Shibo Li <zzutcyha@....com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fix multiple line dereference

On 2/20/23 09:40, Shibo Li wrote:
> This patch fixes the following warning in rtl871x_mlme.c
> 
> WARNING: Avoid multiple line dereference - prefer 'adapter->securitypriv.PrivacyAlgrthm'
> 
> Signed-off-by: Shibo Li <zzutcyha@....com>
> ---
>   drivers/staging/rtl8712/rtl871x_mlme.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index 63e12b157001..cc47c1cedd4e 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -773,8 +773,8 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf)
>   						adapter->securitypriv.busetkipkey = false;
>   						adapter->securitypriv.bgrpkey_handshake = false;
>   						ptarget_sta->ieee8021x_blocked = true;
> -						ptarget_sta->XPrivacy = adapter->
> -						securitypriv.PrivacyAlgrthm;
> +						ptarget_sta->XPrivacy =
> +							adapter->securitypriv.PrivacyAlgrthm;
>   						memset((u8 *)&ptarget_sta->x_UncstKey,
>   							 0,
>   							 sizeof(union Keytype));

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> AW-NU120