linux-kernel - Re: [PATCH] wifi: ath11k: fix SAC bug on peer addition with sta band migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63f3c697.5d0a0220.8f9f5.c859@mx.google.com>
Date:   Mon, 20 Feb 2023 14:51:05 +0100
From:   Christian Marangi <ansuelsmth@...il.com>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, ath11k@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] wifi: ath11k: fix SAC bug on peer addition with sta band
 migration

On Mon, Feb 20, 2023 at 08:57:51AM +0000, Kalle Valo wrote:
> Christian Marangi <ansuelsmth@...il.com> wrote:
> 
> > Fix sleep in atomic context warning detected by Smatch static checker
> > analyzer.
> > 
> > Following the locking pattern for peer_rhash_add lock tbl_mtx_lock mutex
> > always even if sta is not transitioning to another band.
> > This is peer_add function and a more secure locking should not cause
> > performance regression.
> > 
> > Fixes: d673cb6fe6c0 ("wifi: ath11k: fix peer addition/deletion error on sta band migration")
> > Reported-by: Dan Carpenter <error27@...il.com>
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>
> 
> I assume you only compile tested this and I'll add that to the commit log. It's
> always good to know how the patch was tested.
> 

Hi, I just got time to test this and works correctly on my Xiaomi
AX3600.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

-- 
	Ansuel