lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMuHMdV4efVX8X1KoLJ-3pmzsxnU6TODw3b_37ZK771rfrqi7A@mail.gmail.com> Date: Tue, 21 Feb 2023 11:03:14 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Baoquan He <bhe@...hat.com> Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, arnd@...db.de, hch@...radead.org, mcgrof@...nel.org Subject: Re: [RFC PATCH 2/2] arch/*/io.h: remove ioremap_uc in some architectures Hi Baoquan, Thanks for your patch! On Tue, Feb 21, 2023 at 7:36 AM Baoquan He <bhe@...hat.com> wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior, everywhere else this is the same as ioremap() anyway. > > So here, remove the ioremap_uc() definition in architecutures other > than x86 and ia64. These architectures all have asm-generic/io.h > included and will have the default ioremap_uc() definition which > returns NULL. If any ARCH really needs a specific ioremap_uc() for Please make it very clear that this changes existing behavior. At first, I had completely missed that. And of course the documentation should be updated to reflect that. > its own usage, one ioremap_uc() can be added in the ARH. s/ARH/ARCH/ > arch/m68k/include/asm/kmap.h | 1 - Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists