linux-kernel - Re: [RFC PATCH 2/2] arch/*/io.h: remove ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/StIdIVz3iP00UP@MiWiFi-R3L-srv>
Date:   Tue, 21 Feb 2023 19:38:09 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org, arnd@...db.de,
        hch@...radead.org, mcgrof@...nel.org
Subject: Re: [RFC PATCH 2/2] arch/*/io.h: remove ioremap_uc in some
 architectures

On 02/21/23 at 11:03am, Geert Uytterhoeven wrote:
> Hi Baoquan,
> 
> Thanks for your patch!
> 
> On Tue, Feb 21, 2023 at 7:36 AM Baoquan He <bhe@...hat.com> wrote:
> > ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> > extension, and on ia64 with its slightly unconventional ioremap()
> > behavior, everywhere else this is the same as ioremap() anyway.
> >
> > So here, remove the ioremap_uc() definition in architecutures other
> > than x86 and ia64. These architectures all have asm-generic/io.h
> > included and will have the default ioremap_uc() definition which
> > returns NULL. If any ARCH really needs a specific ioremap_uc() for
> 
> Please make it very clear that this changes existing behavior.
> At first, I had completely missed that.

Sure, I will update log.

> 
> And of course the documentation should be updated to reflect that.

Makes sense, will do.

> 
> > its own usage, one ioremap_uc() can be added in the ARH.
> 
> s/ARH/ARCH/

Will update.

> 
> >  arch/m68k/include/asm/kmap.h   | 1 -
> 
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks for reviewing.