linux-kernel - Re: [PATCH v4 01/21] net/tcp: Prepare tcp_md5sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/Qv3eEk+1zytBGG@gondor.apana.org.au>
Date:   Tue, 21 Feb 2023 10:43:41 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Dmitry Safonov <dima@...sta.com>
Cc:     linux-kernel@...r.kernel.org, David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andy Lutomirski <luto@...capital.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bob Gilligan <gilligan@...sta.com>,
        David Laight <David.Laight@...lab.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Eric Biggers <ebiggers@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Francesco Ruggeri <fruggeri05@...il.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ivan Delalande <colona@...sta.com>,
        Leonard Crestez <cdleonard@...il.com>,
        Salam Noureddine <noureddine@...sta.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v4 01/21] net/tcp: Prepare tcp_md5sig_pool for TCP-AO

On Mon, Feb 20, 2023 at 04:57:20PM +0000, Dmitry Safonov wrote:
. 
> Do you have a timeline for that work?
> And if you don't mind I keep re-iterating, as I'm trying to address TCP
> reviews and missed functionality/selftests.

I'm hoping to get it ready for the next merge window.
 
> 1) before your per-request key patches - it's not possible.
> 2) after your patches - my question would be: "is it better to
> kmalloc(GFP_ATOMIC) in RX/TX for every signed TCP segment, rather than
> pre-allocate it?"
> 
> The price of (2) may just well be negligible, but worth measuring before
> switching.

Please keep in mind that you're already performing crypto which
is usually a lot slower than a kmalloc.  In any case, if there is
any optimisation to be done to make the kmalloc faster by using
pools, then that optimisation should go into mm.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt