linux-kernel - Re: [PATCH 2/8] perf bpf filter: Implement event sample filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7ciwJXp2LEpZHSifgjbHwzhvAEkGEQxdas0LFMN3rNHCyg@mail.gmail.com>
Date:   Wed, 22 Feb 2023 11:49:13 -0800
From:   Namhyung Kim <namhyung@...nel.org>
To:     Jiri Olsa <olsajiri@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Song Liu <song@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Leo Yan <leo.yan@...aro.org>,
        James Clark <james.clark@....com>, Hao Luo <haoluo@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH 2/8] perf bpf filter: Implement event sample filtering

On Tue, Feb 21, 2023 at 3:54 AM Jiri Olsa <olsajiri@...il.com> wrote:
>
> On Sat, Feb 18, 2023 at 10:13:23PM -0800, Namhyung Kim wrote:
>
> SNIP
>
> > +#define FD(e, x, y) (*(int *)xyarray__entry(e->core.fd, x, y))
> > +
> > +int perf_bpf_filter__prepare(struct evsel *evsel)
> > +{
> > +     int i, x, y, fd;
> > +     struct sample_filter_bpf *skel;
> > +     struct bpf_program *prog;
> > +     struct bpf_link *link;
> > +     struct perf_bpf_filter_expr *expr;
> > +
> > +     skel = sample_filter_bpf__open();
> > +     if (!skel) {
> > +             pr_err("Failed to open perf sample-filter BPF skeleton\n");
> > +             return -1;
> > +     }
> > +
> > +     bpf_map__set_max_entries(skel->maps.filters, MAX_FILTERS);
>
> is this needed? max_entries is defined in the bpf object

Nop, will remove.

Thanks,
Namhyung