linux-kernel - Re: [PATCH 3/8] perf record: Add BPF event filter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cj_gm7m344Q4GS2v4cBzJWqL=s0POON-9e9DE4p8ohX-Q@mail.gmail.com>
Date:   Wed, 22 Feb 2023 11:50:45 -0800
From:   Namhyung Kim <namhyung@...nel.org>
To:     Jiri Olsa <olsajiri@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Song Liu <song@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Leo Yan <leo.yan@...aro.org>,
        James Clark <james.clark@....com>, Hao Luo <haoluo@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH 3/8] perf record: Add BPF event filter support

On Tue, Feb 21, 2023 at 3:54 AM Jiri Olsa <olsajiri@...il.com> wrote:
>
> On Sat, Feb 18, 2023 at 10:13:24PM -0800, Namhyung Kim wrote:
>
> SNIP
>
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index 8374117e66f6..6429915d376d 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -52,6 +52,7 @@
> >  #include "util/pmu-hybrid.h"
> >  #include "util/evlist-hybrid.h"
> >  #include "util/off_cpu.h"
> > +#include "util/bpf-filter.h"
> >  #include "asm/bug.h"
> >  #include "perf.h"
> >  #include "cputopo.h"
> > @@ -1364,6 +1365,14 @@ static int record__open(struct record *rec)
> >
> >       session->evlist = evlist;
> >       perf_session__set_id_hdr_size(session);
> > +
> > +     evlist__for_each_entry(evlist, pos) {
> > +             if (list_empty(&pos->bpf_filters))
> > +                     continue;
> > +             rc = perf_bpf_filter__prepare(pos);
> > +             if (rc)
> > +                     break;
> > +     }
>
> might fit better under evlist__apply_filters ?

Right, it'd be better.  Will move.

Thanks,
Namhyung