linux-kernel - Re: [PATCH] mm/khugepaged: alloc_charge_hpage() take care of mem charge errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=HUj7FkbyJ6WKVwNhsFv9RMgbXz5KSisnWcTNF5jZe4YdiaQ@mail.gmail.com>
Date:   Wed, 22 Feb 2023 13:03:55 +0900
From:   David Stevens <stevensd@...omium.org>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Yang Shi <shy828301@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] mm/khugepaged: alloc_charge_hpage() take care of mem
 charge errors

On Wed, Feb 22, 2023 at 6:43 AM Peter Xu <peterx@...hat.com> wrote:
>
> If memory charge failed, the caller shouldn't call mem_cgroup_uncharge().
> Let alloc_charge_hpage() handle the error itself and clear hpage properly
> if mem charge fails.
>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Yang Shi <shy828301@...il.com>
> Cc: David Stevens <stevensd@...omium.org>
> Cc: stable@...r.kernel.org
> Fixes: 9d82c69438d0 ("mm: memcontrol: convert anon and file-thp to new mem_cgroup_charge() API")
> Signed-off-by: Peter Xu <peterx@...hat.com>

Reviewed-by: David Stevens <stevensd@...omium.org>