linux-kernel - Alpha MTD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4da501dc-65af-ee89-441d-d3ef8867c64d@infradead.org>
Date:   Tue, 21 Feb 2023 21:37:21 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Richard Henderson <richard.henderson@...aro.org>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>
Cc:     linux-alpha@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Alpha MTD_TSUNAMI BROKEN?

Hi,

In an alpha kernel config with CONFIG_ALPHA_TSUNAMI=y
and CONFIG_MTD_TSUNAMI=y, the MTD driver build fails with:

../drivers/mtd/maps/tsunami_flash.c: In function 'tsunami_flash_read8':
../drivers/mtd/maps/tsunami_flash.c:21:20: error: implicit declaration of function 'tsunami_tig_readb'; did you mean 'tsunami_readb'? [-Werror=implicit-function-declaration]
   21 |         val.x[0] = tsunami_tig_readb(offset);
      |                    ^~~~~~~~~~~~~~~~~
      |                    tsunami_readb
../drivers/mtd/maps/tsunami_flash.c: In function 'tsunami_flash_write8':
../drivers/mtd/maps/tsunami_flash.c:27:9: error: implicit declaration of function 'tsunami_tig_writeb'; did you mean 'tsunami_writeb'? [-Werror=implicit-function-declaration]
   27 |         tsunami_tig_writeb(value.x[0], offset);
      |         ^~~~~~~~~~~~~~~~~~
      |         tsunami_writeb

The tsunami_tig_{readb,writeb{}() functions are completely missing.
I don't see any macros that would generate such function names.

I have searched both kernel/git/history/history.git and
kernel/git/mpe/linux-fullhistory.git (both at git.kernel.org)
and found no such functions. (It's possible that I could have
missed something here: all I did was 'git grep tsunami_tig'.
Do I need to do 'git checkout <something really old>' first?)

Should these functions just be tsunami_readb() and tsunami_writeb()
like the compiler asks?
Or should we mark this driver as BROKEN?

Thanks.
-- 
~Randy