linux-kernel - Re: [PATCH V3 3/8] soundwire: amd: register SoundWire manager dai ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2023 11:09:13 +0530
From:   "Mukunda,Vijendar" <vijendar.mukunda@....com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        vkoul@...nel.org
Cc:     alsa-devel@...a-project.org, amadeuszx.slawinski@...ux.intel.com,
        Mario.Limonciello@....com, Sunil-kumar.Dommati@....com,
        Basavaraj.Hiregoudar@....com, Mastan.Katragadda@....com,
        Arungopal.kondaveeti@....com,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 3/8] soundwire: amd: register SoundWire manager dai ops

On 22/02/23 05:18, Pierre-Louis Bossart wrote:
>
> On 2/21/23 16:05, Mukunda,Vijendar wrote:
>> On 21/02/23 21:29, Pierre-Louis Bossart wrote:
>>>
>>>> +static const struct snd_soc_dai_ops amd_sdw_dai_ops = {
>>>> +	.hw_params = amd_sdw_hw_params,
>>> don't you need a .prepare to deal with suspend-resume?
>> DSP based solution is not implemented yet.
>> As per our understanding In .prepare () callback, there is
>> no extra logic needs to be implemented. Because of it,
>> we have dropped .prepare() callback.
> You don't need any logic IF the IP keeps its context while suspended.
> That wasn't the case for us, we had to re-program the registers when
> resuming.
In our case, IP keeps its context while suspend. No need to implement
.prepare() callback.