linux-kernel - Re: [PATCH] Update documentation of vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0100018676b0882f-5895463a-0af2-4fae-9e0b-8d4676347b1f-000000@email.amazonses.com>
Date:   Wed, 22 Feb 2023 01:15:26 +0000
From:   Hok Chun NG (Ben) <me@...benng.net>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     viro@...iv.linux.org.uk 
        <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org 
        <linux-fsdevel@...r.kernel.org>,
        linux-kernel@...r.kernel.org 
        <linux-kernel@...r.kernel.org>,
        skhan@...uxfoundation.org 
        <skhan@...uxfoundation.org>
Subject: Re: [PATCH] Update documentation of vfs_tmpfile

Hi Bagas,

> On Feb 21, 2023, at 8:21 AM, Bagas Sanjaya <bagasdotme@...il.com> wrote:
> 
> On Tue, Feb 21, 2023 at 03:55:54AM +0000, Hok Chun NG (Ben) wrote:
>> On function vfs_tmpfile, documentation is updated according to function signature update.
>> 
>> Description for 'dentry' and 'open_flag' removed.
>> Description for 'parentpath' and 'file' added.
> 
> What commit did vfs_tmpfile() change its signature?

Changes of the function signature is from 9751b338656f05a0ce918befd5118fcd970c71c6
vfs: move open right after ->tmpfile() by Miklos Szeredi mszeredi@...hat.com

> 
> For the patch description, I'd like to write "Commit <commit> changes
> function signature for vfs_tmpfile(). Catch the function documentation
> up with the change."

I agree. Thank you for the suggestion.

> 
> Thanks.
> 
> -- 
> An old man doll... just what I always wanted! - Clara

Best,
Ben