linux-kernel - Re: [PATCH] Update documentation of vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1635643-a4a8-61e1-7798-af7455668878@gmail.com>
Date:   Wed, 22 Feb 2023 09:32:54 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     "Hok Chun NG (Ben)" <me@...benng.net>
Cc:     "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "skhan@...uxfoundation.org" <skhan@...uxfoundation.org>
Subject: Re: [PATCH] Update documentation of vfs_tmpfile

On 2/22/23 08:15, Hok Chun NG (Ben) wrote:
> Hi Bagas,
> 
>> On Feb 21, 2023, at 8:21 AM, Bagas Sanjaya <bagasdotme@...il.com> wrote:
>>
>> On Tue, Feb 21, 2023 at 03:55:54AM +0000, Hok Chun NG (Ben) wrote:
>>> On function vfs_tmpfile, documentation is updated according to function signature update.
>>>
>>> Description for 'dentry' and 'open_flag' removed.
>>> Description for 'parentpath' and 'file' added.
>>
>> What commit did vfs_tmpfile() change its signature?
> 
> Changes of the function signature is from 9751b338656f05a0ce918befd5118fcd970c71c6
> vfs: move open right after ->tmpfile() by Miklos Szeredi mszeredi@...hat.com
> 

Nice.

The preferred git pretty format when referring to existing commit is
"%h (\"%s\")". Make sure that you set core.abbrev to at least 12.
 
>>
>> For the patch description, I'd like to write "Commit <commit> changes
>> function signature for vfs_tmpfile(). Catch the function documentation
>> up with the change."
> 
> I agree. Thank you for the suggestion.
> 

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara