linux-kernel - Re: [PATCH 1/2] tty: ipwireless: move Kconfig entry to tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2023 09:20:53 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Jiri Slaby" <jirislaby@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, "Jiri Kosina" <jikos@...nel.org>,
        "David Sterba" <dsterba@...e.com>,
        "Dominik Brodowski" <linux@...inikbrodowski.net>
Subject: Re: [PATCH 1/2] tty: ipwireless: move Kconfig entry to tty

On Wed, Feb 22, 2023, at 09:50, Jiri Slaby (SUSE) wrote:
> The ipwireless' Kconfig entry is currently sitting in char/pcmcia. But
> the driver is in tty/. So move the entry to tty/ too.
>
> First, it makes sense to have the entry along the driver. Second, whole
> char/pcmcia is about to pass away.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: David Sterba <dsterba@...e.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

This is clearly correct

Reviewed-by: Arnd Bergmann <arnd@...db.de>

In Dominik's list from
https://lore.kernel.org/all/Y07d7rMvd5++85BJ@owl.dominikbrodowski.net/

he had listed this driver as 'some activity in 2021', but all I can
find are treewide cleanups (mostly from you) after some work by David
in 2008 and Dominik's own PCMCIA rework in 2010. My guess is that
most likely this driver can be removed entirely, but you and David
are the ones who know if there are still users.

     Arnd