linux-kernel - Re: [PATCH 1/2] tty: ipwireless: move Kconfig entry to tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230223172403.GW10580@suse.cz>
Date:   Thu, 23 Feb 2023 18:24:03 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
        David Sterba <dsterba@...e.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>
Subject: Re: [PATCH 1/2] tty: ipwireless: move Kconfig entry to tty

On Thu, Feb 23, 2023 at 09:20:53AM +0100, Arnd Bergmann wrote:
> On Wed, Feb 22, 2023, at 09:50, Jiri Slaby (SUSE) wrote:
> > The ipwireless' Kconfig entry is currently sitting in char/pcmcia. But
> > the driver is in tty/. So move the entry to tty/ too.
> >
> > First, it makes sense to have the entry along the driver. Second, whole
> > char/pcmcia is about to pass away.
> >
> > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> > Cc: Jiri Kosina <jikos@...nel.org>
> > Cc: David Sterba <dsterba@...e.com>
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> This is clearly correct
> 
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> 
> In Dominik's list from
> https://lore.kernel.org/all/Y07d7rMvd5++85BJ@owl.dominikbrodowski.net/
> 
> he had listed this driver as 'some activity in 2021', but all I can
> find are treewide cleanups (mostly from you) after some work by David
> in 2008 and Dominik's own PCMCIA rework in 2010. My guess is that
> most likely this driver can be removed entirely, but you and David
> are the ones who know if there are still users.

The driver works and did not need any development, so the treewide or
minor bugfixes are understandable. I had some discussions with a user in
2011 regarding card detection but otherwise nothing. I can't tell how
many users are there, there are some IPWireless cards in second hand
market and cards for pcmcia can be bought in local shops.
I'd vote for keeping the driver as long as the pcmcia subsystem exists
(option a).