linux-kernel - Re: [PATCH v6 2/5] arm64: dts: qcom: Add msm8939 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a662b604-0bef-6ee4-43d5-0480171539c3@linaro.org>
Date:   Thu, 23 Feb 2023 13:02:54 +0000
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, agross@...nel.org,
        andersson@...nel.org, djakov@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        benl@...areup.com, shawn.guo@...aro.org, fabien.parent@...aro.org,
        leo.yan@...aro.org, dmitry.baryshkov@...aro.org,
        stephan@...hold.net, Jun Nie <jun.nie@...aro.org>,
        James Willcox <jwillcox@...areup.com>,
        Joseph Gates <jgates@...areup.com>,
        Max Chen <mchen@...areup.com>, Zac Crosby <zac@...areup.com>,
        Vincent Knecht <vincent.knecht@...loo.org>
Subject: Re: [PATCH v6 2/5] arm64: dts: qcom: Add msm8939 SoC

On 23/02/2023 12:53, Konrad Dybcio wrote:
> 
> 
> On 23.02.2023 13:51, Bryan O'Donoghue wrote:
>> On 22/02/2023 17:08, Konrad Dybcio wrote:
>>>> +            interrupt-names = "wdog", "fatal", "ready",
>>>> +                      "handover", "stop-ack";
>>> This should be a vertical list
>>>
>>>> +
>>>> +            clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
>>>> +                 <&gcc GCC_MSS_Q6_BIMC_AXI_CLK>,
>>>> +                 <&gcc GCC_BOOT_ROM_AHB_CLK>,
>>>> +                 <&rpmcc RPM_SMD_XO_CLK_SRC>;
>>>> +            clock-names = "iface", "bus", "mem", "xo";
>>> This could also be one
>>>
>>
>> Sorry what are you asking for here Konrad
>>
>> clock-names = "iface",
>>                "bus",
>>
>> if so, why ?
> Yep!
> 
> It's just easier to read.. you don't have to count the
> nth entry in a single line. Maybe this specific example
> is still easy for the human brain to quickly cross-reference,
> longer lists or lists with longer entries than 3 or so are
> confusing..
> 
> Konrad

I'm not necessarily opposed to that, I just don't see much precedent for it.

But... fine.

---
bod