linux-kernel - Re: [PATCH v2] x86/paravirt: merge activate_mm and dup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2023 16:05:51 +0100
From:   Juergen Gross <jgross@...e.com>
To:     "Srivatsa S. Bhat" <srivatsa@...il.mit.edu>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        virtualization@...ts.linux-foundation.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Alexey Makhalov <amakhalov@...are.com>,
        VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2] x86/paravirt: merge activate_mm and dup_mmap callbacks

On 07.02.23 22:09, Srivatsa S. Bhat wrote:
> On 2/6/23 11:59 PM, Juergen Gross wrote:
>> The two paravirt callbacks .mmu.activate_mm and .mmu.dup_mmap are
>> sharing the same implementations in all cases: for Xen PV guests they
>> are pinning the PGD of the new mm_struct, and for all other cases
>> they are a NOP.
>>
>> In the end both callbacks are meant to register an address space with
>> the underlying hypervisor, so there needs to be only a single callback
>> for that purpose.
>>
>> So merge them to a common callback .mmu.enter_mmap (in contrast to the
>> corresponding already existing .mmu.exit_mmap).
>>
>> As the first parameter of the old callbacks isn't used, drop it from
>> the replacement one.
>>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> 
> 
> Reviewed-by: Srivatsa S. Bhat (VMware) <srivatsa@...il.mit.edu>

x86 maintainers, I think this patch should be carried via the tip tree.


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)