linux-kernel - Re: [PATCH] cpufreq: schedutil: make kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jBMtDq5jkWxxDDGyv=vZMFecD3u5WrGUasTtChpA2QOg@mail.gmail.com>
Date:   Thu, 23 Feb 2023 19:58:34 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: schedutil: make kobj_type structure constant

On Tue, Feb 21, 2023 at 5:37 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 20-02-23, 23:28, Thomas Weißschuh wrote:
> > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> > the driver core allows the usage of const struct kobj_type.
> >
> > Take advantage of this to constify the structure definition to prevent
> > modification at runtime.
> >
> > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> > ---
> >  kernel/sched/cpufreq_schedutil.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> > index 1207c78f85c1..4c073bd9b001 100644
> > --- a/kernel/sched/cpufreq_schedutil.c
> > +++ b/kernel/sched/cpufreq_schedutil.c
> > @@ -543,7 +543,7 @@ static void sugov_tunables_free(struct kobject *kobj)
> >       kfree(to_sugov_tunables(attr_set));
> >  }
> >
> > -static struct kobj_type sugov_tunables_ktype = {
> > +static const struct kobj_type sugov_tunables_ktype = {
> >       .default_groups = sugov_groups,
> >       .sysfs_ops = &governor_sysfs_ops,
> >       .release = &sugov_tunables_free,
> >
> > ---
> > base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f
> > change-id: 20230220-kobj_type-cpufreq-schedutil-783c6be6ff14
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied as 6.3-rc material, thanks!