[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y/iq18rYjLwnkBrp@surfacebook>
Date: Fri, 24 Feb 2023 14:17:27 +0200
From: andy.shevchenko@...il.com
To: Jerome Neanne <jneanne@...libre.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, tony@...mide.com,
lee@...nel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-omap@...r.kernel.org,
Jonathan Cormier <jcormier@...ticallink.com>
Subject: Re: [PATCH 2/2] mfd: tps65219: Add gpio cell instance
Fri, Feb 24, 2023 at 12:38:37PM +0100, Jerome Neanne kirjoitti:
> tps65219 PMIC GPIOs are exposed in a standard way:
> gpiodetect
> gpiochip0 [tps65219-gpio] (3 lines)
>
> Signed-off-by: Jonathan Cormier <jcormier@...ticallink.com>
> Signed-off-by: Jerome Neanne <jneanne@...libre.com>
Same issues with the commit message as per previous patch.
...
> @@ -267,6 +267,11 @@ static int tps65219_probe(struct i2c_client *client)
> return ret;
> }
>
> + if (ret) {
> + dev_err(tps->dev, "Failed to add gpio: %d\n", ret);
> + return ret;
> + }
Isn't it a dead code?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists