linux-kernel - Re: [PATCH 5/9] media: i2c: ov5695: convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Feb 2023 13:41:35 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Wolfram Sang <wsa@...nel.org>
Cc:     kernel@...gutronix.de, Shunqian Zheng <zhengsq@...k-chips.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Subject: Re: [PATCH 5/9] media: i2c: ov5695: convert to i2c's .probe_new()

On 24/02/2023 13:05, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

Acked-by: Hans Verkuil <hverkuil-cisco@...all.nl>

> Link: https://lore.kernel.org/lkml/20221121102705.16092-1-u.kleine-koenig@pengutronix.de
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/media/i2c/ov5695.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5695.c b/drivers/media/i2c/ov5695.c
> index 61906fc54e37..b287c28920a6 100644
> --- a/drivers/media/i2c/ov5695.c
> +++ b/drivers/media/i2c/ov5695.c
> @@ -1267,8 +1267,7 @@ static int ov5695_configure_regulators(struct ov5695 *ov5695)
>  				       ov5695->supplies);
>  }
>  
> -static int ov5695_probe(struct i2c_client *client,
> -			const struct i2c_device_id *id)
> +static int ov5695_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct ov5695 *ov5695;
> @@ -1393,7 +1392,7 @@ static struct i2c_driver ov5695_i2c_driver = {
>  		.pm = &ov5695_pm_ops,
>  		.of_match_table = of_match_ptr(ov5695_of_match),
>  	},
> -	.probe		= &ov5695_probe,
> +	.probe_new	= &ov5695_probe,
>  	.remove		= &ov5695_remove,
>  };
>