linux-kernel - Re: [PATCH 6/9] media: i2c: ov2685: convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed37c8c7-92a8-73fe-1451-08695cd4db9f@xs4all.nl>
Date:   Fri, 24 Feb 2023 13:41:44 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Wolfram Sang <wsa@...nel.org>
Cc:     kernel@...gutronix.de, Shunqian Zheng <zhengsq@...k-chips.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Subject: Re: [PATCH 6/9] media: i2c: ov2685: convert to i2c's .probe_new()

On 24/02/2023 13:05, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

Acked-by: Hans Verkuil <hverkuil-cisco@...all.nl>

> Link: https://lore.kernel.org/lkml/20221121102838.16448-1-u.kleine-koenig@pengutronix.de
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/media/i2c/ov2685.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov2685.c b/drivers/media/i2c/ov2685.c
> index a3b524f15d89..1c80b121e7d6 100644
> --- a/drivers/media/i2c/ov2685.c
> +++ b/drivers/media/i2c/ov2685.c
> @@ -707,8 +707,7 @@ static int ov2685_configure_regulators(struct ov2685 *ov2685)
>  				       ov2685->supplies);
>  }
>  
> -static int ov2685_probe(struct i2c_client *client,
> -			const struct i2c_device_id *id)
> +static int ov2685_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct ov2685 *ov2685;
> @@ -830,7 +829,7 @@ static struct i2c_driver ov2685_i2c_driver = {
>  		.pm = &ov2685_pm_ops,
>  		.of_match_table = of_match_ptr(ov2685_of_match),
>  	},
> -	.probe		= &ov2685_probe,
> +	.probe_new	= &ov2685_probe,
>  	.remove		= &ov2685_remove,
>  };
>