linux-kernel - Re: [PATCH] fbdev: omapfb: cleanup inconsistent indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb6900d5-148f-85cb-eebc-c20d99802c75@gmx.de>
Date:   Sat, 25 Feb 2023 18:23:48 +0100
From:   Helge Deller <deller@....de>
To:     Lucy Mielke <mielkesteven@...oud.com>, linux-fbdev@...r.kernel.org,
        linux-omap@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH] fbdev: omapfb: cleanup inconsistent indentation

Hi Lucy,

On 2/7/23 11:06, Lucy Mielke wrote:
> This cleans up the indentation according to the Linux kernel coding
> style, and should fix the warning created by the kernel test robot.
>
> Fixes: 8b08cf2b64f5a60594b07795b2ad518c6d044566 ("OMAP: add TI OMAP
> 	framebuffer driver")
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Lucy Mielke <mielkesteven@...oud.com>
> ---
>   drivers/video/fbdev/omap/omapfb_main.c | 32 +++++++++++++++-----------
>   1 file changed, 19 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index 1f3df2055ff0..4b673daa32cb 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -78,7 +78,7 @@ static struct platform_device omapdss_device = {
>   	.name		= "omapdss_dss",
>   	.id		= -1,
>   	.dev            = {
> -		.release = omapdss_release,
> +	.release	= omapdss_release,>   	},

This is wrong. "release" belongs inside the .dev
variable, so the previous indenting is correct.

The changes below seem correct.

Helge

>   };
>
> @@ -544,19 +544,25 @@ static int set_fb_var(struct fb_info *fbi,
>   		var->yoffset = var->yres_virtual - var->yres;
>
>   	if (plane->color_mode == OMAPFB_COLOR_RGB444) {
> -		var->red.offset	  = 8; var->red.length	 = 4;
> -						var->red.msb_right   = 0;
> -		var->green.offset = 4; var->green.length = 4;
> -						var->green.msb_right = 0;
> -		var->blue.offset  = 0; var->blue.length  = 4;
> -						var->blue.msb_right  = 0;
> +		var->red.offset		= 8;
> +		var->red.length		= 4;
> +		var->red.msb_right	= 0;
> +		var->green.offset	= 4;
> +		var->green.length	= 4;
> +		var->green.msb_right	= 0;
> +		var->blue.offset	= 0;
> +		var->blue.length	= 4;
> +		var->blue.msb_right	= 0;
>   	} else {
> -		var->red.offset	 = 11; var->red.length	 = 5;
> -						var->red.msb_right   = 0;
> -		var->green.offset = 5;  var->green.length = 6;
> -						var->green.msb_right = 0;
> -		var->blue.offset = 0;  var->blue.length  = 5;
> -						var->blue.msb_right  = 0;
> +		var->red.offset		= 11;
> +		var->red.length		= 5;
> +		var->red.msb_right	= 0;
> +		var->green.offset	= 5;
> +		var->green.length	= 6;
> +		var->green.msb_right	= 0;
> +		var->blue.offset	= 0;
> +		var->blue.length	= 5;
> +		var->blue.msb_right	= 0;
>   	}
>
>   	var->height		= -1;