linux-kernel - Re: [PATCH v3 14/20] thermal/drivers/da9062: Don't access the thermal zone device fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Feb 2023 19:14:17 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     DLG Adam Ward <DLG-Adam.Ward.opensource@...renesas.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Support Opensource <support.opensource@...semi.com>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, rafael@...nel.org
Subject: Re: [PATCH v3 14/20] thermal/drivers/da9062: Don't access the thermal
 zone device fields


Hi Adam,

are you ok with this patch ?


On 26/02/2023 23:54, Daniel Lezcano wrote:
> The driver is reading the passive polling rate in the thermal zone
> structure. We want to prevent the drivers to rummage around in the
> thermal zone structure.
> 
> On the other side, the delay is what the driver passed to the
> thermal_zone_device_register() function, so it has already the
> information.
> 
> Reuse the information we have instead of reading the information we
> set.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>   drivers/thermal/da9062-thermal.c | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-thermal.c
> index e7097f354750..2d31b1f73423 100644
> --- a/drivers/thermal/da9062-thermal.c
> +++ b/drivers/thermal/da9062-thermal.c
> @@ -41,6 +41,8 @@
>   
>   #define DA9062_MILLI_CELSIUS(t)			((t) * 1000)
>   
> +static unsigned int pp_tmp = DA9062_DEFAULT_POLLING_MS_PERIOD;
> +
>   struct da9062_thermal_config {
>   	const char *name;
>   };
> @@ -95,7 +97,10 @@ static void da9062_thermal_poll_on(struct work_struct *work)
>   		thermal_zone_device_update(thermal->zone,
>   					   THERMAL_EVENT_UNSPECIFIED);
>   
> -		delay = thermal->zone->passive_delay_jiffies;
> +		/*
> +		 * pp_tmp is between 1s and 10s, so we can round the jiffies
> +		 */
> +		delay = round_jiffies(msecs_to_jiffies(pp_tmp));
>   		queue_delayed_work(system_freezable_wq, &thermal->work, delay);
>   		return;
>   	}
> @@ -155,7 +160,6 @@ static int da9062_thermal_probe(struct platform_device *pdev)
>   {
>   	struct da9062 *chip = dev_get_drvdata(pdev->dev.parent);
>   	struct da9062_thermal *thermal;
> -	unsigned int pp_tmp = DA9062_DEFAULT_POLLING_MS_PERIOD;
>   	const struct of_device_id *match;
>   	int ret = 0;
>   
> @@ -208,8 +212,7 @@ static int da9062_thermal_probe(struct platform_device *pdev)
>   	}
>   
>   	dev_dbg(&pdev->dev,
> -		"TJUNC temperature polling period set at %d ms\n",
> -		jiffies_to_msecs(thermal->zone->passive_delay_jiffies));
> +		"TJUNC temperature polling period set at %d ms\n", pp_tmp);
>   
>   	ret = platform_get_irq_byname(pdev, "THERMAL");
>   	if (ret < 0)

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog