linux-kernel - Re: [PATCH 1/3] tty: n_gsm: add ioctl for DLC specific parameter configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2023 18:51:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     "D. Starke" <daniel.starke@...mens.com>,
        linux-serial@...r.kernel.org, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, ilpo.jarvinen@...ux.intel.com
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Daniel Starke <daniel.starke@...mens.com>
Subject: Re: [PATCH 1/3] tty: n_gsm: add ioctl for DLC specific parameter
 configuration

Hi Starke,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus]
[cannot apply to v6.2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/D-Starke/tty-n_gsm-allow-window-size-configuration/20230228-143349
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/20230228062957.3150-1-daniel.starke%40siemens.com
patch subject: [PATCH 1/3] tty: n_gsm: add ioctl for DLC specific parameter configuration
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230228/202302281856.S9Lz4gHB-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/06d7556b46ca2395b18cb700f19ee5de37d8383b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review D-Starke/tty-n_gsm-allow-window-size-configuration/20230228-143349
        git checkout 06d7556b46ca2395b18cb700f19ee5de37d8383b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302281856.S9Lz4gHB-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/tty/n_gsm.c: In function 'gsmld_ioctl':
>> drivers/tty/n_gsm.c:3720:26: warning: unused variable 'dlci' [-Wunused-variable]
    3720 |         struct gsm_dlci *dlci;
         |                          ^~~~


vim +/dlci +3720 drivers/tty/n_gsm.c

  3713	
  3714	static int gsmld_ioctl(struct tty_struct *tty, unsigned int cmd,
  3715			       unsigned long arg)
  3716	{
  3717		struct gsm_config c;
  3718		struct gsm_config_ext ce;
  3719		struct gsm_mux *gsm = tty->disc_data;
> 3720		struct gsm_dlci *dlci;
  3721		unsigned int base;
  3722	
  3723		switch (cmd) {
  3724		case GSMIOC_GETCONF:
  3725			gsm_copy_config_values(gsm, &c);
  3726			if (copy_to_user((void __user *)arg, &c, sizeof(c)))
  3727				return -EFAULT;
  3728			return 0;
  3729		case GSMIOC_SETCONF:
  3730			if (copy_from_user(&c, (void __user *)arg, sizeof(c)))
  3731				return -EFAULT;
  3732			return gsm_config(gsm, &c);
  3733		case GSMIOC_GETFIRST:
  3734			base = mux_num_to_base(gsm);
  3735			return put_user(base + 1, (__u32 __user *)arg);
  3736		case GSMIOC_GETCONF_EXT:
  3737			gsm_copy_config_ext_values(gsm, &ce);
  3738			if (copy_to_user((void __user *)arg, &ce, sizeof(ce)))
  3739				return -EFAULT;
  3740			return 0;
  3741		case GSMIOC_SETCONF_EXT:
  3742			if (copy_from_user(&ce, (void __user *)arg, sizeof(ce)))
  3743				return -EFAULT;
  3744			return gsm_config_ext(gsm, &ce);
  3745		default:
  3746			return n_tty_ioctl_helper(tty, cmd, arg);
  3747		}
  3748	}
  3749	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests