linux-kernel - Re: [PATCH v3 22/34] superh: Implement the new page table range API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVY9VSZ57g-RXpDVBigfKJZLyF5wuyRsbmOm6d+m08OEA@mail.gmail.com>
Date:   Wed, 1 Mar 2023 09:06:16 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     linux-mm@...ck.org, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        linux-sh@...r.kernel.org
Subject: Re: [PATCH v3 22/34] superh: Implement the new page table range API

Hi Willy,

On Tue, Feb 28, 2023 at 10:39 PM Matthew Wilcox (Oracle)
<willy@...radead.org> wrote:
> Add set_ptes(), update_mmu_cache_range(), flush_dcache_folio() and
> flush_icache_pages().  Change the PG_dcache_clean flag from being
> per-page to per-folio.  Flush the entire folio containing the pages in
> flush_icache_pages() for ease of implementation.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Thanks for your patch!

> --- a/arch/sh/mm/cache.c
> +++ b/arch/sh/mm/cache.c

>  void __flush_anon_page(struct page *page, unsigned long vmaddr)
>  {
> +       struct folio *folio = page_folio(page);
>         unsigned long addr = (unsigned long) page_address(page);
>
>         if (pages_do_alias(addr, vmaddr)) {
> -               if (boot_cpu_data.dcache.n_aliases && page_mapcount(page) &&
> -                   test_bit(PG_dcache_clean, &page->flags)) {
> +               if (boot_cpu_data.dcache.n_aliases && folio_mapped(folio) &&
> +                   test_bit(PG_dcache_clean, &folio->flags)) {
>                         void *kaddr;
>
>                         kaddr = kmap_coherent(page, vmaddr);
>                         /* XXX.. For now kunmap_coherent() does a purge */
>                         /* __flush_purge_region((void *)kaddr, PAGE_SIZE); */
>                         kunmap_coherent(kaddr);
> -               } else
> -                       __flush_purge_region((void *)addr, PAGE_SIZE);
> +               } else

Trailing whitespace. Please run scripts/checkpath.pl (on the full series).

> +                       __flush_purge_region(folio_address(folio),
> +                                               folio_size(folio));
>         }
>  }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds