linux-kernel - Re: [PATCH v3 22/34] superh: Implement the new page table range API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/96gfG1vpfdTzZO@casper.infradead.org>
Date:   Wed, 1 Mar 2023 16:17:05 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-mm@...ck.org, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        linux-sh@...r.kernel.org
Subject: Re: [PATCH v3 22/34] superh: Implement the new page table range API

On Wed, Mar 01, 2023 at 09:06:16AM +0100, Geert Uytterhoeven wrote:
> > -               } else
> > -                       __flush_purge_region((void *)addr, PAGE_SIZE);
> > +               } else
> 
> Trailing whitespace. Please run scripts/checkpath.pl (on the full series).

Thanks.  It's pretty noisy and I don't intend to clean up many of
those warnings, but it did find some legit problems.

I'll squash these fixes into v4.

diff --git a/arch/powerpc/include/asm/pgtable.h b/arch/powerpc/include/asm/pgtable.h
index bf1263ff7e67..45e5282f406c 100644
--- a/arch/powerpc/include/asm/pgtable.h
+++ b/arch/powerpc/include/asm/pgtable.h
@@ -45,7 +45,7 @@ void set_ptes(struct mm_struct *mm, unsigned long addr, pte_t *ptep,
 		pte_t pte, unsigned int nr);
 #define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1)
 #define update_mmu_cache(vma, addr, ptep) \
-	update_mmu_cache_range(vma, addr, ptep, 1);
+	update_mmu_cache_range(vma, addr, ptep, 1)
 
 #ifndef MAX_PTRS_PER_PGD
 #define MAX_PTRS_PER_PGD PTRS_PER_PGD
diff --git a/arch/sh/mm/cache.c b/arch/sh/mm/cache.c
index 93fc5fb8ec1c..9bcaa5619eab 100644
--- a/arch/sh/mm/cache.c
+++ b/arch/sh/mm/cache.c
@@ -169,7 +169,7 @@ void __flush_anon_page(struct page *page, unsigned long vmaddr)
 			/* XXX.. For now kunmap_coherent() does a purge */
 			/* __flush_purge_region((void *)kaddr, PAGE_SIZE); */
 			kunmap_coherent(kaddr);
-		} else 
+		} else
 			__flush_purge_region(folio_address(folio),
 						folio_size(folio));
 	}
diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h
index d5c0088e0c6a..0c30b0eb6c57 100644
--- a/arch/sparc/include/asm/pgtable_64.h
+++ b/arch/sparc/include/asm/pgtable_64.h
@@ -924,7 +924,7 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr,
 	}
 }
 
-#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1);
+#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1)
 
 #define pte_clear(mm,addr,ptep)		\
 	set_pte_at((mm), (addr), (ptep), __pte(0UL))
diff --git a/arch/xtensa/mm/cache.c b/arch/xtensa/mm/cache.c
index 65c0d5298041..27bd798e4d89 100644
--- a/arch/xtensa/mm/cache.c
+++ b/arch/xtensa/mm/cache.c
@@ -254,7 +254,7 @@ void update_mmu_cache_range(struct vm_area_struct *vma, unsigned long addr,
 			void *paddr = kmap_local_folio(folio, i * PAGE_SIZE);
 			__flush_dcache_page((unsigned long)paddr);
 			__invalidate_icache_page((unsigned long)paddr);
-			kunmap_atomic(paddr);
+			kunmap_local(paddr);
 		}
 		set_bit(PG_arch_1, &folio->flags);
 	}

> > +                       __flush_purge_region(folio_address(folio),
> > +                                               folio_size(folio));
> >         }
> >  }
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds