[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230301093102.f76wulx4mo7435qz@pengutronix.de>
Date: Wed, 1 Mar 2023 10:31:02 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: Jindong Yue <jindong.yue@....com>
Cc: shawnguo@...nel.org, s.hauer@...gutronix.de, peng.fan@....com,
gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
linux-imx@....com, kernel@...gutronix.de, festevam@...il.com,
l.stach@...gutronix.de
Subject: Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use
dev_pm_domain_attach_by_name
Hi,
thanks for the patch.
On 23-03-01, Jindong Yue wrote:
> The genpd_dev_pm_attach_by_name() is not exported, it should not be used
> by consumer driver.
> Use dev_pm_domain_attach_by_name() instead.
I'm not sure if this is the correct reason. If it wouldn't be allowed to
be used by consumers it would/should be private. Instead you should
mention here that you need the symbol for possible module builds. Same
applies to the other patches.
Regards,
Marco
>
> Signed-off-by: Jindong Yue <jindong.yue@....com>
> ---
> drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c
> index a0592db8fa86..1892c2c78831 100644
> --- a/drivers/soc/imx/imx8mp-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c
> @@ -642,7 +642,7 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev)
> if (!bc->onecell_data.domains)
> return -ENOMEM;
>
> - bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");
> + bc->bus_power_dev = dev_pm_domain_attach_by_name(dev, "bus");
> if (IS_ERR(bc->bus_power_dev))
> return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> "failed to attach bus power domain\n");
> --
> 2.36.0
>
>
>
Powered by blists - more mailing lists