linux-kernel - RE: Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use dev_pm_domain_attach_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <GV1PR04MB91834769F5276CED6D0F9623FBAD9@GV1PR04MB9183.eurprd04.prod.outlook.com>
Date:   Wed, 1 Mar 2023 12:31:42 +0000
From:   "J.D. Yue" <jindong.yue@....com>
To:     Marco Felsch <m.felsch@...gutronix.de>
CC:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        Peng Fan <peng.fan@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>
Subject: RE: Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use
 dev_pm_domain_attach_by_name


> -----Original Message-----
> From: Marco Felsch <m.felsch@...gutronix.de>
> Sent: Wednesday, March 1, 2023 5:31 PM
> To: J.D. Yue <jindong.yue@....com>
> Cc: shawnguo@...nel.org; s.hauer@...gutronix.de; Peng Fan
> <peng.fan@....com>; gregkh@...uxfoundation.org;
> linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> kernel@...gutronix.de; festevam@...il.com; l.stach@...gutronix.de
> Subject: [EXT] Re: [PATCH v2 1/7] soc: imx: imx8mp-blk-ctrl: Use
> dev_pm_domain_attach_by_name
> 
> 
> Hi,
> 
> thanks for the patch.
> 
> On 23-03-01, Jindong Yue wrote:
> > The genpd_dev_pm_attach_by_name() is not exported, it should not be
> > used by consumer driver.
> > Use dev_pm_domain_attach_by_name() instead.
> 
> I'm not sure if this is the correct reason. If it wouldn't be allowed to be used by
> consumers it would/should be private. Instead you should mention here that
> you need the symbol for possible module builds. Same applies to the other
> patches.
> 

You are correct, I ran into symbol undefined errors when building this driver as a module.
I will update the commit message in v3 as you suggested. Thank you very much.

> Regards,
>   Marco
> 
> >
> > Signed-off-by: Jindong Yue <jindong.yue@....com>
> > ---
> >  drivers/soc/imx/imx8mp-blk-ctrl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c
> > b/drivers/soc/imx/imx8mp-blk-ctrl.c
> > index a0592db8fa86..1892c2c78831 100644
> > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c
> > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c
> > @@ -642,7 +642,7 @@ static int imx8mp_blk_ctrl_probe(struct
> platform_device *pdev)
> >       if (!bc->onecell_data.domains)
> >               return -ENOMEM;
> >
> > -     bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");
> > +     bc->bus_power_dev = dev_pm_domain_attach_by_name(dev, "bus");
> >       if (IS_ERR(bc->bus_power_dev))
> >               return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> >                                    "failed to attach bus power
> > domain\n");
> > --
> > 2.36.0
> >
> >
> >