[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <B43602D1-89D4-465F-83B1-CD106E07CB29@flygoat.com>
Date: Wed, 1 Mar 2023 14:18:10 +0000
From: Jiaxun Yang <jiaxun.yang@...goat.com>
To: Christoph Hellwig <hch@....de>
Cc: "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
mpe@...erman.id.au, paul.walmsley@...ive.com, palmer@...belt.com,
Rob Herring <robh+dt@...nel.org>, m.szyprowski@...sung.com,
robin.murphy@....com, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for
default coherency
> 2023年3月1日 13:06,Christoph Hellwig <hch@....de> 写道:
>
>> - select OF_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE
>
> Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now,
> or even better should be doing that in the patch adding that
> symbol?
If I read the code correctly for powerpc OF_DMA_DEFAULT_COHERENT is only selected
with !NOT_COHERENT_CACHE, which means non-coherent dma support is disabled….
>
> In fact I wonder if adding CONFIG_ARCH_DMA_DEFAULT_COHERENT and removing
> OF_DMA_DEFAULT_COHERENT should be one patch, as that seems to bring
> over the intent a little better I'd say.
Powered by blists - more mailing lists