linux-kernel - Re: [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j2rao56aVegCPj=ZM+SJSGyXbbnwyuXz=WPZ9y+7BBMA@mail.gmail.com>
Date:   Wed, 1 Mar 2023 19:34:06 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Yegnesh S Iyer <yegnesh.s.iyer@...el.com>,
        Bin Gao <bin.gao@...el.com>, Zhang Rui <rui.zhang@...el.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of
 depending on it

On Sun, Feb 26, 2023 at 6:40 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: b474303ffd57 ("thermal: add Intel BXT WhiskeyCove PMIC thermal driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Yegnesh S Iyer <yegnesh.s.iyer@...el.com>
> Cc: Bin Gao <bin.gao@...el.com>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Rafael J. Wysocki <rafael@...nel.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Amit Kucheria <amitk@...nel.org>
> Cc: linux-pm@...r.kernel.org
> ---
>  drivers/thermal/intel/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -73,7 +73,8 @@ endmenu
>
>  config INTEL_BXT_PMIC_THERMAL
>         tristate "Intel Broxton PMIC thermal driver"
> -       depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
> +       depends on X86 && INTEL_SOC_PMIC_BXTWC
> +       select REGMAP
>         help
>           Select this driver for Intel Broxton PMIC with ADC channels monitoring
>           system temperature measurements and alerts.

Applied as 6.3-rc material, thanks!