[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230302091614.62093-1-jeff.pang.chn@gmail.com>
Date: Thu, 2 Mar 2023 17:16:14 +0800
From: Jeff Pang <jeff.pang.chn@...il.com>
To: evan.quan@....com
Cc: amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org,
Jeff Pang <jeff.pang.chn@...il.com>
Subject: [PATCH] gpu: amd/pm: mark symbols static where possible for smu11
I get one warning when building kernel with -Werror=missing-prototypes :
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1600:5:
error: no previous prototype for ‘vangogh_set_apu_thermal_limit’
[-Werror=missing-prototypes]
int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit)
In fact, this function don't need a declaration due to it's only used
in the file which they are.
So this patch marks the function with 'static'.
Signed-off-by: Jeff Pang <jeff.pang.chn@...il.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 016d5621e0b3..24046af60933 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -1597,7 +1597,7 @@ static int vangogh_get_apu_thermal_limit(struct smu_context *smu, uint32_t *limi
0, limit);
}
-int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit)
+static int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit)
{
return smu_cmn_send_smc_msg_with_param(smu,
SMU_MSG_SetReducedThermalLimit,
--
2.34.1
Powered by blists - more mailing lists