[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b0a5c0c2-dfbd-460a-af0d-c9d498607d72@sirena.org.uk>
Date: Thu, 2 Mar 2023 12:20:18 +0000
From: Mark Brown <broonie@...nel.org>
To: richard.leitner@...ux.dev
Cc: Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Ladislav Michl <ladis@...ux-mips.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Benjamin Bara <benjamin.bara@...data.com>,
alsa-devel@...a-project.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Richard Leitner <richard.leitner@...data.com>
Subject: Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support
On Thu, Mar 02, 2023 at 12:55:03PM +0100, richard.leitner@...ux.dev wrote:
> + max9867->mclk = devm_clk_get(&i2c->dev, "mclk");
> + if (IS_ERR(max9867->mclk))
> + return PTR_ERR(max9867->mclk);
> + ret = clk_prepare_enable(max9867->mclk);
> + if (ret < 0)
> + dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret);
> +
Nothing ever disables the clock - we need a disable in the remove path
at least.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists