linux-kernel - Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61e4485b-9211-fa38-5061-f5861292ddd1@microchip.com>
Date:   Thu, 2 Mar 2023 12:45:50 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <broonie@...nel.org>, <richard.leitner@...ux.dev>
CC:     <lgirdwood@...il.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <ladis@...ux-mips.org>,
        <tiwai@...e.com>, <benjamin.bara@...data.com>,
        <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <richard.leitner@...data.com>
Subject: Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support

On 02.03.2023 14:20, Mark Brown wrote:
>> +	max9867->mclk = devm_clk_get(&i2c->dev, "mclk");
>> +	if (IS_ERR(max9867->mclk))
>> +		return PTR_ERR(max9867->mclk);
>> +	ret = clk_prepare_enable(max9867->mclk);
>> +	if (ret < 0)
>> +		dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret);
>> +
> Nothing ever disables the clock - we need a disable in the remove path
> at least.

I don't have the full context of this patch but this diff seems a good
candidate for devm_clk_get_enabled().