linux-kernel - RE: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2023 18:18:19 +0530
From:   "Shradha Todi" <shradha.t@...sung.com>
To:     "'Rob Herring'" <robh@...nel.org>
Cc:     <pankaj.dubey@...sung.com>, <linux-pci@...r.kernel.org>,
        <jingoohan1@...il.com>, <jh80.chung@...sung.co>,
        <linux-arm-kernel@...ts.infradead.org>, <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>, <hongxing.zhu@....com>,
        <alim.akhtar@...sung.com>, <bhelgaas@...gle.com>,
        <krzysztof.kozlowski+dt@...aro.org>, <m.szyprowski@...sung.com>,
        <kw@...ux.com>, <devicetree@...r.kernel.org>,
        <Sergey.Semin@...kalelectronics.ru>,
        <linux-samsung-soc@...r.kernel.org>, <lukas.bulwahn@...il.com>,
        <lpieralisi@...nel.org>
Subject: RE: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required
 property



> -----Original Message-----
> From: Rob Herring [mailto:robh@...nel.org]
> Sent: 14 February 2023 21:43
> To: Shradha Todi <shradha.t@...sung.com>
> Cc: pankaj.dubey@...sung.com; linux-pci@...r.kernel.org;
> jingoohan1@...il.com; jh80.chung@...sung.co; linux-arm-
> kernel@...ts.infradead.org; tglx@...utronix.de; linux-
> kernel@...r.kernel.org; hongxing.zhu@....com;
> alim.akhtar@...sung.com; bhelgaas@...gle.com;
> krzysztof.kozlowski+dt@...aro.org; m.szyprowski@...sung.com;
> kw@...ux.com; devicetree@...r.kernel.org;
> Sergey.Semin@...kalelectronics.ru; linux-samsung-soc@...r.kernel.org;
> lukas.bulwahn@...il.com; lpieralisi@...nel.org
> Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required
> property
> 
> 
> On Tue, 14 Feb 2023 17:43:27 +0530, Shradha Todi wrote:
> > To replace devm_of_phy_get with devm_phy_get to get the PHY pointer
> > using non DT version, we need to add phy-names property in DT and make
> > it a required property with const value.
> >
> > Signed-off-by: Shradha Todi <shradha.t@...sung.com>
> > ---
> >  Documentation/devicetree/bindings/pci/samsung,pcie.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/samsung,exynos-
> pcie.example.dtb: pcie@...00000: 'phy-names' is a required property
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
> 
> doc reference errors (make refcheckdocs):
> 
> See https://protect2.fireeye.com/v1/url?k=788bbab7-19f652f0-788a31f8-
> 74fe485fff30-c0e59906b0eee0e1&q=1&e=33c2cefb-9526-43d7-9446-
> b159854d2369&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fdev
> icetree-bindings%2Fpatch%2F20230214121333.1837-11-
> shradha.t%40samsung.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.

Thanks for review. Sorry, I missed to update the example. Anyway I will get rid of this patch all together!