linux-kernel - RE: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2023 18:21:35 +0530
From:   "Shradha Todi" <shradha.t@...sung.com>
To:     "'Rob Herring'" <robh@...nel.org>
Cc:     <lpieralisi@...nel.org>, <kw@...ux.com>, <bhelgaas@...gle.com>,
        <krzysztof.kozlowski+dt@...aro.org>, <alim.akhtar@...sung.com>,
        <jingoohan1@...il.com>, <Sergey.Semin@...kalelectronics.ru>,
        <lukas.bulwahn@...il.com>, <hongxing.zhu@....com>,
        <tglx@...utronix.de>, <m.szyprowski@...sung.com>,
        <jh80.chung@...sung.co>, <pankaj.dubey@...sung.com>,
        <linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required
 property



> -----Original Message-----
> From: Rob Herring [mailto:robh@...nel.org]
> Sent: 15 February 2023 00:48
> To: Shradha Todi <shradha.t@...sung.com>
> Cc: lpieralisi@...nel.org; kw@...ux.com; bhelgaas@...gle.com;
> krzysztof.kozlowski+dt@...aro.org; alim.akhtar@...sung.com;
> jingoohan1@...il.com; Sergey.Semin@...kalelectronics.ru;
> lukas.bulwahn@...il.com; hongxing.zhu@....com; tglx@...utronix.de;
> m.szyprowski@...sung.com; jh80.chung@...sung.co;
> pankaj.dubey@...sung.com; linux-pci@...r.kernel.org;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required
> property
> 
> On Tue, Feb 14, 2023 at 05:43:27PM +0530, Shradha Todi wrote:
> > To replace devm_of_phy_get with devm_phy_get to get the PHY pointer
> > using non DT version, we need to add phy-names property in DT and make
> > it a required property with const value.
> 
> Also an ABI break.
> 
> And unnecessary. You don't need a name with a single entry. Pretty sure I
> fixed that for phy_get at some point.
> 

Thanks, I got your point. I will drop this. As of now we have only single
PHYs for Samsung and it can be handled
via phy_get API without a name as you highlighted.

Shradha

> Rob