[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230303110250.GE2420672@google.com>
Date: Fri, 3 Mar 2023 11:02:50 +0000
From: Lee Jones <lee@...nel.org>
To: Nick Alcock <nick.alcock@...cle.com>
Cc: mcgrof@...nel.org, linux-modules@...r.kernel.org,
linux-kernel@...r.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH 04/27] mfd: intel_soc_pmic_crc: remove MODULE_LICENSE in
non-modules
On Fri, 24 Feb 2023, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Andy Shevchenko <andy@...nel.org>
> Cc: Lee Jones <lee@...nel.org>
> ---
> drivers/mfd/intel_soc_pmic_crc.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists