linux-kernel - Re: [PATCH 04/27] mfd: intel_soc_pmic_crc: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lek97qvc.fsf@esperi.org.uk>
Date:   Mon, 06 Mar 2023 17:04:55 +0000
From:   Nick Alcock <nick.alcock@...cle.com>
To:     Lee Jones <lee@...nel.org>
Cc:     Andy Shevchenko <andy@...nel.org>, mcgrof@...nel.org,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
Subject: Re: [PATCH 04/27] mfd: intel_soc_pmic_crc: remove MODULE_LICENSE in
 non-modules

On 3 Mar 2023, Lee Jones spake thusly:

> On Fri, 24 Feb 2023, Andy Shevchenko wrote:
>
>> On Fri, Feb 24, 2023 at 03:07:48PM +0000, Nick Alcock wrote:
>> > Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> > are used to identify modules. As a consequence, uses of the macro
>> > in non-modules will cause modprobe to misidentify their containing
>> > object file as a module when it is not (false positives), and modprobe
>> > might succeed rather than failing with a suitable error message.
>> > 
>> > So remove it in the files in this commit, none of which can be built as
>> > modules.
>> > 
>> > Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
>> > Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
>> 
>> > Cc: Luis Chamberlain <mcgrof@...nel.org>
>> > Cc: linux-modules@...r.kernel.org
>> > Cc: linux-kernel@...r.kernel.org
>> > Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
>> > Cc: Andy Shevchenko <andy@...nel.org>
>> > Cc: Lee Jones <lee@...nel.org>
>> 
>> Please, use --cc parameter instead of polluting commit message.
>
> I personally use this a lot.  It's better for scripting.

Yeah.

If this is generally annoying I guess I can rejig things to use --cc-cmd
instead, somehow, but it was very convenient because it meant the
machinery which split up the commits could also compute the Cc list at
the same time without having to record it separately, but I assumed it
was routinely done from the number of Cc: trailers already in the kernel
tree...