linux-kernel - Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 10:35:53 -0500
From:   Peter Xu <peterx@...hat.com>
To:     David Stevens <stevensd@...omium.org>
Cc:     linux-mm@...ck.org, Matthew Wilcox <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Yang Shi <shy828301@...il.com>,
        David Hildenbrand <david@...hat.com>,
        Hugh Dickins <hughd@...gle.com>, linux-kernel@...r.kernel.org,
        Zach O'Keefe <zokeefe@...gle.com>
Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races

On Fri, Feb 17, 2023 at 05:54:36PM +0900, David Stevens wrote:
> From: David Stevens <stevensd@...omium.org>
> 
> Fix two races in khugepaged+shmem that cause issues with userfaultfd and
> lseek, respectively.
> 
> v3 -> v4:
>  - Base changes on mm-everything (fba720cb4dc0)
>  - Add patch to refactor error handling control flow in collapse_file
>  - Rebase userfaultfd patch with no significant logic changes
>  - Different approach for fixing lseek race

I just noticed this one hasn't landed unstable, so I guess I just posted a
trivial cleanup that can conflict with this so it won't apply cleanly..

https://lore.kernel.org/r/20230303151218.311015-1-peterx@redhat.com

The resolution will be fairly straightforward though, and I'm happy to
rebase that one to this since this targets a real bug so should have higher
priority.

I guess it's possible Andrew thought the series has unsettled comment so
Andrew could just have ignored that whole set in the mark ups.  A repost
could possibly clarify that.

Again, it'll always great to get another eye on this slightly involved
series. Matthew / Yang were already on the list, also copying Zach for his
recent works on khugepaged just in case he spots anything wrong.

Thanks,

-- 
Peter Xu