linux-kernel - Re: [PATCH] qede: remove linux/version.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Mar 2023 16:35:32 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>
CC:     Ariel Elior <aelior@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, <kernel@...labora.com>,
        <kernel-janitors@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] qede: remove linux/version.h

From: Muhammad Usama Anjum <usama.anjum@...labora.com>
Date: Fri,  3 Mar 2023 17:58:44 +0500

> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
> 
> So remove linux/version.h from both of these files.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
>  drivers/net/ethernet/qlogic/qede/qede.h         | 1 -
>  drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
> index f90dcfe9ee68..6ff1bd48d2aa 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede.h
> +++ b/drivers/net/ethernet/qlogic/qede/qede.h
> @@ -7,7 +7,6 @@
>  #ifndef _QEDE_H_
>  #define _QEDE_H_
>  #include <linux/compiler.h>

I think compiler.h is also unused, maybe this one too, while at it?

> -#include <linux/version.h>
>  #include <linux/workqueue.h>
>  #include <linux/netdevice.h>
>  #include <linux/interrupt.h>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> index 8034d812d5a0..374a86b875a3 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> @@ -4,7 +4,6 @@
>   * Copyright (c) 2019-2020 Marvell International Ltd.
>   */
>  
> -#include <linux/version.h>
>  #include <linux/types.h>
>  #include <linux/netdevice.h>
>  #include <linux/etherdevice.h>

Thanks,
Olek